Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-223 ignore failure at parsing df output #225

Merged
merged 1 commit into from
Sep 22, 2016

Conversation

mbaechler
Copy link
Contributor

No description provided.

@mbaechler
Copy link
Contributor Author

see #223


if (availableMB < 2048) {
if (df.availableMB.orElseThrow(NotAbleToGetDiskSpaceUsageException::new) < 2048) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this throw an exception if free space can't be found?

I think that would be too harsh - maybe the nicest behaviour if the df check returns nothing is to just let the process carry on. It would probably be annoying for a user to be blocked completely just because df doesn't work in their environment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's exactly what I did : the exception is caught into checkDiskSpaceAndHandleExceptions and it just logs a warning. Is that ok to you ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah OK cool - I'd missed the next stage. Thanks.

@rnorth
Copy link
Member

rnorth commented Sep 22, 2016

Thanks for this - will merge now.

@rnorth rnorth merged commit 0358304 into testcontainers:master Sep 22, 2016
@mbaechler
Copy link
Contributor Author

great, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants